Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: 1.3.2 -> 1.4.4 #63658

Merged
merged 1 commit into from Jul 29, 2019
Merged

podman: 1.3.2 -> 1.4.4 #63658

merged 1 commit into from Jul 29, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jun 22, 2019 •
edited

Motivation for this change

Update podman to the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
Copy link
Member Author

Ah I saw that we have #63353, too. I can rebase on top :)

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build podman

bachp
bachp approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@bachp bachp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it's working

vdemeester
vdemeester approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯
I am fine with closing mine 😉

@saschagrunert
Copy link
Member Author

LGTM
I am fine with closing mine

Oh that's nice, tanks 🙏

@worldofpeace
Copy link
Contributor

https://github.com/containers/libpod/releases/tag/v1.4.4 is released.

When you update this PR @saschagrunert feel free to ping so I can merge it.

@saschagrunert
podman: 1.3.2 -> 1.4.4
31feec6 
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
@saschagrunert
Copy link
Member Author

https://github.com/containers/libpod/releases/tag/v1.4.4 is released.

When you update this PR @saschagrunert feel free to ping so I can merge it.

Hey @worldofpeace thanks for the hint. I updated it to 1.4.4 and changed the SHA as well as the commit message.

@worldofpeace worldofpeace changed the title podman: 1.3.2 -> 1.4.2 podman: 1.3.2 -> 1.4.4 Jul 29, 2019
@worldofpeace
Copy link
Contributor

Get an error when running it without any arguments

Error: could not get runtime: could not find a working conmon binary (configured options: [/usr/libexec/podman/conmon /usr/local/lib/podman/conmon /usr/bin/conmon /usr/sbin/conmon /usr/local/bin/conmon /usr/local/sbin/conmon]): invalid argument

This conf doesn't look nixos friendly

Should this be something we're concerned with?

@saschagrunert
Copy link
Member Author

Get an error when running it without any arguments

Error: could not get runtime: could not find a working conmon binary (configured options: [/usr/libexec/podman/conmon /usr/local/lib/podman/conmon /usr/bin/conmon /usr/sbin/conmon /usr/local/bin/conmon /usr/local/sbin/conmon]): invalid argument

This conf doesn't look nixos friendly

Should this be something we're concerned with?

Not right now, since I always have to provide my own config to get things working on nixos. I will follow up on this topic and will add the current system path there, but I think this is not the only problematic configuration option...

@worldofpeace
Copy link
Contributor

Huh, yeah rather problematic 🤣

I'm not sure why they need to configuration option for paths to executables, but maybe like a build flag would help downstreams.

@worldofpeace worldofpeace merged commit acb6758 into NixOS:master Jul 29, 2019
@saschagrunert saschagrunert deleted the podman branch July 29, 2019 08:04
@saschagrunert
Copy link
Member Author

Huh, yeah rather problematic

I'm not sure why they need to configuration option for paths to executables, but maybe like a build flag would help downstreams.

I already implemented a path discovery feature for executables in CRI-O, so let's see if we can put it into libpod as well. :)

@saschagrunert
Copy link
Member Author

Thanks for the fast response 🙏

@worldofpeace
Copy link
Contributor

Thanks for the fast response 🙏

Active nixpkgs times for me 😄 .

If you ever think something's good for merge I'm typically responsive.

@saschagrunert saschagrunert mentioned this pull request Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@bachp bachp bachp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @worldofpeace @vdemeester @bachp