Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hdbscan: fix build #63659

Merged
merged 1 commit into from
Jun 25, 2019
Merged

pythonPackages.hdbscan: fix build #63659

merged 1 commit into from
Jun 25, 2019
+3 −11

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 22, 2019 •
edited
Loading

Motivation for this change

Newer hdbscan came sooner than I was expecting. don't need the upstream patch anymore. Also seems to need joblib, added for the benefit of the py27 version, whose scikitlearn doesn't include it.

Won't build until #63573 is fixed, hence draft.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@risicle risicle force-pushed the ris-hdbscan-fix-remove branch from 1815203 to c58442f Compare June 22, 2019 16:24
@risicle risicle marked this pull request as ready for review June 22, 2019 16:25
@risicle risicle requested a review from FRidh as a code owner June 22, 2019 16:25
@risicle risicle force-pushed the ris-hdbscan-fix-remove branch from c58442f to 9974650 Compare June 22, 2019 18:06
@risicle
pythonPackages.hdbscan: fix build by removing upstream patch, adding …

Verified

This commit was signed with the committer’s verified signature. The key has expired.
infinisil Silvan Mosberger
GPG key ID: E8F1E9EAD284E17D
Expired
Verified
Learn about vigilant mode
8008954 
…joblib

joblib is for the benefit of py27, whose scikitlearn doesn't include it.
also move cython to nativeBuildInputs
@risicle risicle force-pushed the ris-hdbscan-fix-remove branch from 9974650 to 8008954 Compare June 22, 2019 18:07
@risicle risicle changed the title pythonPackages.hdbscan: fix build by removing upstream patch pythonPackages.hdbscan: fix build Jun 22, 2019
worldofpeace
worldofpeace approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build on NixOS with python 3.7 and 2.7 for me.

@worldofpeace worldofpeace merged commit 813f1b5 into NixOS:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@risicle @worldofpeace