Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dua: init at 2.1.5 #63656

Merged
merged 2 commits into from Jul 3, 2019
Merged

dua: init at 2.1.5 #63656

merged 2 commits into from Jul 3, 2019

Conversation

killercup
Copy link
Member

A tool to conveniently learn about the disk usage of directories, fast!

Adds lock file that was missing from upstream repo.

Adds myself to maintainers list.

Motivation for this change

Add initial version of nice alternative to du.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few changes I've mentioned which I hope you'll find helpful. Thanks for contributing this tool, I'm very interested in trying it.

pkgs/tools/misc/dua/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/dua/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/dua/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/dua/default.nix Show resolved Hide resolved
@killercup killercup changed the title dua: init at 2.1.3 dua: init at 2.1.5 Jul 3, 2019
@killercup
Copy link
Member Author

Thanks for the review, @aanderse! Updated to freshly released 2.1.5 and addressed all comments :)

> A tool to conveniently learn about the disk usage of directories, fast!
@aanderse
Copy link
Member

aanderse commented Jul 3, 2019

@GrahamcOfBorg build dua

@aanderse
Copy link
Member

aanderse commented Jul 3, 2019

After reading upstream documentation I'm confused as to what the package name is: dua or dua-cli. I think it is dua-cli... maybe 🤷‍♂️

As per the manual:

The name attribute should be identical to the upstream package name.

@killercup
Copy link
Member Author

@aanderse hm, I assumed this is only called dua-cli because it would otherwise conflict on crates.io with another package called dua. The binary is also called dua and it only ever referred to as dua except for the repo/rust library name.

It's up to you. I don't mind changing it.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as is because what you said makes sense to me. Thank you very much for your contribution @killercup!

@aanderse aanderse merged commit 04c5735 into NixOS:master Jul 3, 2019
@killercup
Copy link
Member Author

Awesome, thanks again for the great feedback, @aanderse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants