Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia-tool: init at 0.9.0 #63655

Merged
merged 1 commit into from Jul 29, 2019
Merged

sequoia-tool: init at 0.9.0 #63655

merged 1 commit into from Jul 29, 2019

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Jun 22, 2019 •
edited

Motivation for this change

A user-friendly PGP tool: https://sequoia-pgp.org/

  • The command-line program is actually called "sq" but the Rust package is called "sequoia-tool". I wasn't sure which to choose so I went with the one with the least chance of collision.
  • I didn't manage to build it entirely on my laptop because it kept running out of memory / space, so if someone would like to test it locally, or trigger ofborg, I would really appreciate it ^^
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@minijackson minijackson mentioned this pull request Jun 22, 2019
Closed
@risicle
Copy link
Contributor

risicle commented Jun 23, 2019

Builds for me on non-nixos linux x86_64 too. I've pushed the resultant closure of /nix/store/yfgbng5kkp68kghq48l2925cklhqkidd-sequoia-tool-0.8.0 up to https://ris.cachix.org/ if you want to inspect it.

@minijackson
Copy link
Member Author

Thanks a lot @risicle! I've played with it a bit, and it seems to run quite fine ^^

@minijackson minijackson changed the title sequoia-tool: init at 0.8.0 sequoia-tool: init at 0.9.0 Jul 8, 2019
@sauyon
Copy link
Member

sauyon commented Jul 15, 2019

Works for me on Arch, what needs to be done to get this merged?

@minijackson
Copy link
Member Author

Some attention, I think ^^

@worldofpeace worldofpeace merged commit 872b55a into NixOS:master Jul 29, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 29, 2019 •
edited

Thank you @minijackson.

If you ever feel like a change looks good, has all the approvals, and you feel meets the marks, feel free to ping me personally, or I can help you find someone to review a change.

@minijackson
Copy link
Member Author

Thank you @worldofpeace !

@minijackson minijackson deleted the init-sequoia-tool branch September 14, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minijackson @risicle @sauyon @worldofpeace