-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python packages #63692
Add python packages #63692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No argparse
, there is no valid reason for that package because we don't support Python < 2.7
Which packages are missing those dependencies? |
Thanks for the feedback! If I remove argparse, entrypoint2 won't build anymore:
And sorry for the confusion: I wanted to add pylint-django and django-jenkins, therefore I had to add some other (currently missing) dependencies. |
Kind of hacky, but you could use |
The package ( |
a354251
to
ffe298d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually see the disabled logic inside of the nix expression.
Not sure how strong others feel about this.
ffe298d
to
c58b24a
Compare
Thank you very much for your input! |
@FRidh are the changes I made okay? It shows that you didn't resolve your change request |
Ping |
What is the status? |
31c96a6
to
ba84953
Compare
@GrahamcOfBorg build python2Packages.django-jenkins python3Packages.django-jenkins python2Packages.pyvirtualdisplay python3Packages.pyvirtualdisplay python2Packages.pyscreenshot python3Packages.pyscreenshot python2Packages.entrypoint2 python3Packages.entrypoint2 python2Packages.django-tables2 python3Packages.django-tables2 python2Packages.pylint-plugin-utils python3Packages.pylint-plugin-utils python3Packages.pylint-django |
Which packages are missing those dependencies? Edit: nevermind, I see it now:
|
@FRidh I suppose he is referring to his own project. |
Yes, I'm sorry, that souded very misleading.. This PR is self contained and ready to be merged. There is nothing missing here :) |
Motivation for this change
Added multiple python packages because of missing dependencies
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)