Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python packages #63692

Closed
wants to merge 7 commits into from
Closed

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Added multiple python packages because of missing dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No argparse, there is no valid reason for that package because we don't support Python < 2.7

@FRidh
Copy link
Member

FRidh commented Jun 23, 2019

Added multiple python packages because of missing dependencies

Which packages are missing those dependencies?

@Gerschtli
Copy link
Contributor Author

Thanks for the feedback!

If I remove argparse, entrypoint2 won't build anymore:

removing build/bdist.linux-x86_64/wheel
installing
/build/entrypoint2-0.0.6/dist /build/entrypoint2-0.0.6
Processing ./entrypoint2-0.0.0-py3-none-any.whl
Requirement already satisfied: decorator in /nix/store/80wi4jym5nkg5p6djf6s23m2m5hkzji0-python3.7-decorator-4.3.2/lib/python3.7/site-packages (from entrypoint2==0.0.0) (4.3.2)
Collecting argparse (from entrypoint2==0.0.0)
  ERROR: Could not find a version that satisfies the requirement argparse (from entrypoint2==0.0.0) (from versions: none)
ERROR: No matching distribution found for argparse (from entrypoint2==0.0.0)
builder for '/nix/store/189azqcsqp0sdlckc372imdrdxifw7i6-python3.7-entrypoint2-0.0.6.drv' failed with exit code 1
error: build of '/nix/store/189azqcsqp0sdlckc372imdrdxifw7i6-python3.7-entrypoint2-0.0.6.drv' failed

And sorry for the confusion: I wanted to add pylint-django and django-jenkins, therefore I had to add some other (currently missing) dependencies.

@jonringer
Copy link
Contributor

If I remove argparse, entrypoint2 won't build anymore

Kind of hacky, but you could use substituteInPlace setup.py --replace "argparse" "". Then it wont assert that a argparse is found on the pythonpath

@FRidh
Copy link
Member

FRidh commented Jun 23, 2019

If I remove argparse, entrypoint2 won't build anymore:

The package (setup.py) should not declare a dependency on argparse, and should thus be fixed, preferably upstream.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually see the disabled logic inside of the nix expression.

Not sure how strong others feel about this.

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@Gerschtli
Copy link
Contributor Author

Thank you very much for your input!

@Gerschtli
Copy link
Contributor Author

@FRidh are the changes I made okay? It shows that you didn't resolve your change request

@Gerschtli
Copy link
Contributor Author

Ping

@Gerschtli
Copy link
Contributor Author

What is the status?

@Gerschtli
Copy link
Contributor Author

@GrahamcOfBorg build python2Packages.django-jenkins python3Packages.django-jenkins python2Packages.pyvirtualdisplay python3Packages.pyvirtualdisplay python2Packages.pyscreenshot python3Packages.pyscreenshot python2Packages.entrypoint2 python3Packages.entrypoint2 python2Packages.django-tables2 python3Packages.django-tables2 python2Packages.pylint-plugin-utils python3Packages.pylint-plugin-utils python3Packages.pylint-django

@FRidh
Copy link
Member

FRidh commented Sep 22, 2019

Added multiple python packages because of missing dependencies

Which packages are missing those dependencies?

Edit:

nevermind, I see it now:

I wanted to add pylint-django and django-jenkins, therefore I had to add some other (currently missing) dependencies.

@Mic92
Copy link
Member

Mic92 commented Sep 22, 2019

@FRidh I suppose he is referring to his own project.

@FRidh FRidh self-requested a review September 22, 2019 14:59
@Gerschtli
Copy link
Contributor Author

Yes, I'm sorry, that souded very misleading.. This PR is self contained and ready to be merged. There is nothing missing here :)

@Gerschtli Gerschtli closed this Jan 8, 2020
@Gerschtli Gerschtli deleted the update/python-packages branch August 31, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants