openalSolf, mpv: fix, enable HRTF support #63628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without those data files HRTF will silently fail to initialize. It searches /usr and /usr/local by default but we don't have those paths. It also searches XDG_DATA_DIRS but using that requires configuration by the user. This patch makes makes it just work. How to play with it: - Build `mpv` with `openalSoft` support. - cat << EOF > ~/.alsoftrc [general] hrtf = true EOF - Wear stereo headphones. - Play a file with 6 or more channels with `mpv -ao openal $file`, e.g. https://archive.org/download/5.1SurroundSoundTestFilesVariousFormatsAACAC3MP4DTSWAV/5.1%20Surround%20Sound%20AAC%20Test.mp4 - Try `hrtf = false` to hear the difference.
See the previous commit.
ofborg
bot
added
6.topic: nixos
6.topic: python
6.topic: steam
8.has: module (update)
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
8.has: clean-up
8.has: package (new)
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
and removed
6.topic: nixos
6.topic: python
6.topic: steam
8.has: module (update)
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
labels
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
labels
|
I just tried this out on the example 5.1 file you posted, with Without the patch, it plays no audio, with the patch it manages conversion to stereo. It still doesn’t approach the pulseaudio downsampling though (channels to the front are the same loudness as channels to the back). I assume that’s what the HRTF files do. Update: even when adding the |
Profpatsch
approved these changes
Oct 29, 2019
|
But it is a net improvement, so I think we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixing HRTF (see https://en.wikipedia.org/wiki/Head-related_transfer_function) functionality in
openalSolfand then enabling it by defeault inmpvis the simplest way I found to get proper sound output for media files with more than two channels of audio.For instance, say you want to properly hear all of the channels of a 5.1 movie while wearing stereo headphones. Applying this patchset makes it magically work in plain simple
mpvwithout any hacking with ALSA mapping tables, PulseAudio, jackd, etc.As a nice bonus, using this also allows to map
mpvsound output with a HRTF. The default HRTF that comes withopenalSolfis not particularly awesome, but it works, and it can be easily configured via~/.alsoftrcif desired.git logopenalSolf: make it search its own $out for data files
Without those data files HRTF will silently fail to initialize.
It searches /usr and /usr/local by default but we don't have those paths.
It also searches XDG_DATA_DIRS but using that requires configuration by the
user. This patch makes makes it just work.
How to play with it:
Build
mpvwithopenalSoftsupport.cat << EOF > ~/.alsoftrc
[general]
hrtf = true
EOF
Wear stereo headphones.
Play a file with 6 or more channels with
mpv -ao openal $file, e.g.https://archive.org/download/5.1SurroundSoundTestFilesVariousFormatsAACAC3MP4DTSWAV/5.1%20Surround%20Sound%20AAC%20Test.mp4
Try
hrtf = falseto hear the difference.mpv: enable openal support by default
See the previous commit.
nix-instantiateenvironmentnix-env -qaPdiffs