Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomcat: CVE-2019-10072 #63618

Merged
merged 2 commits into from Jun 24, 2019
Merged

tomcat: CVE-2019-10072 #63618

merged 2 commits into from Jun 24, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Jun 21, 2019

Motivation for this change

According to this announcement:
http://mail-archives.us.apache.org/mod_mbox/www-announce/201906.mbox/%3Cca69531a-1592-be7b-60ce-729549c7f812%40apache.org%3E

.. both the 8.5 and 9 versions we have in nixpkgs are vulnerable. I ran the tomcat nixos test with services.tomcat.package set to tomcat85 and tomcat9. Both tests passed locally.

Not sure of the severity of the CVE. Perhaps this should be backported to 19.03 as well.

@GrahamcOfBorg build tomcat85 tomcat9

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Jun 24, 2019

Pushed to 19.03 in 53346d7 and beyond. Thanks!

@johanot johanot deleted the tomcat-9.0.21-master branch June 24, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants