Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neomutt: remove mutt wrapper #63687

Merged
merged 1 commit into from Jun 23, 2019
Merged

neomutt: remove mutt wrapper #63687

merged 1 commit into from Jun 23, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 23, 2019

Since Oct 14, 2017 we warned users still executing neomutt
through the mutt binary, so we can assume everybody read the notice,
updated his config, and can drop the wrapper.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
neomutt: remove mutt wrapper
5ada40d 
Since Oct 14, 2017 we warned users still executing `neomutt`
through the `mutt` binary, so we can assume everybody read the notice,
updated his config, and can drop the wrapper.
@flokli flokli requested review from Mic92, andir and peterhoeg June 23, 2019 12:23
@ofborg ofborg bot requested review from vrthra and cstrahan June 23, 2019 12:37
peterhoeg
peterhoeg approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@peterhoeg peterhoeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mic92 Mic92 merged commit 80172aa into NixOS:master Jun 23, 2019
@flokli flokli mentioned this pull request May 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@andir andir Awaiting requested review from andir

@vrthra vrthra Awaiting requested review from vrthra

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @peterhoeg @Mic92