Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conftest: init at 0.7.0 #63610

Merged
merged 1 commit into from Jun 23, 2019
Merged

conftest: init at 0.7.0 #63610

merged 1 commit into from Jun 23, 2019

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 21, 2019

Motivation for this change

Add conftest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Jun 21, 2019

@GrahamcOfBorg build conftest

@yurrriq
Copy link
Member Author

yurrriq commented Jun 21, 2019

@GrahamcOfBorg build conftest

@ofborg ofborg bot requested a review from kalbasit June 21, 2019 10:36
@kalbasit
Copy link
Member

@GrahamcOfBorg build conftest

kalbasit
kalbasit requested changes Jun 21, 2019
View reviewed changes
pkgs/development/tools/conftest/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/conftest/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/conftest/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/conftest/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from kalbasit June 21, 2019 21:29
@yurrriq
Copy link
Member Author

yurrriq commented Jun 22, 2019

Thanks for the feedback, @kalbasit. This should be good to review now.

@yurrriq
Copy link
Member Author

yurrriq commented Jun 22, 2019

@GrahamcOfBorg build conftest

1 similar comment
@kalbasit
Copy link
Member

@GrahamcOfBorg build conftest

@kalbasit kalbasit merged commit 2b5ba7f into NixOS:master Jun 23, 2019
@yurrriq yurrriq deleted the add/conftest branch June 24, 2019 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurrriq @kalbasit