moodle: init at 3.7.1 #63634

aanderse · 2019-06-21T21:05:03Z

Motivation for this change

https://discourse.nixos.org/t/writing-my-own-local-httpd-subservice/3194

Things not yet done but need to be before merged

Find a maintainer so meta can be completed in the package
Testing by someone who actually knows how to use moodle

Things done

nixos-discourse · 2019-06-21T21:16:15Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/writing-my-own-local-httpd-subservice/3194/3

nixos/modules/services/web-apps/moodle.nix

aanderse · 2019-06-24T21:24:45Z

Thanks @JohnAZoidberg. I always appreciate review catching the little things 😄 As mentioned, revisions to come.

nixos/modules/services/web-apps/moodle.nix

pmiddend · 2019-06-27T10:53:47Z

Okay, I've had time to test this using the instructions you provided on discourse. My configuration is as minimal as can be:

services.moodle = {
  enable = true;
  initialPassword = "foobar";    
  virtualHost = {
    hostName = "moodle.example.org";
    enableSSL = false;
    adminAddr = "webmaster@example.org";
  };
};

This results in the following error:

Jun 27 12:50:14 hypnos systemd[1]: Starting moodle-init.service...
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: !!! <p>Error: Database connection failed</p>
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: <p>It is possible that the database is overloaded or otherwise not running properly.</p>
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: <p>The site administrator should also check that the database details have been correctly specified in config.php</p> !!!
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: !!! <p>Error: Database connection failed</p>
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: <p>It is possible that the database is overloaded or otherwise not running properly.</p>
Jun 27 12:50:14 hypnos ainriknxqms310gm3k19d7bzca3vznj4-unit-script-moodle-init-start[21008]: <p>The site administrator should also check that the database details have been correctly specified in config.php</p> !!!
Jun 27 12:50:14 hypnos systemd[1]: moodle-init.service: Main process exited, code=exited, status=1/FAILURE
Jun 27 12:50:14 hypnos systemd[1]: moodle-init.service: Failed with result 'exit-code'.
Jun 27 12:50:14 hypnos systemd[1]: Failed to start moodle-init.service.

● mysql.service - MySQL Server
   Loaded: loaded (/nix/store/0d5ni4q3w0mbkx0dq3r3szqzxzrqch29-unit-mysql.service/mysql.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Thu 2019-06-27 12:50:14 CEST; 628ms ago
  Process: 20967 ExecStartPre=/nix/store/4yvyv354mckk037gx1dgpmydy3pw56b3-unit-script-mysql-pre-start (code=exited, status=0/SUCCESS)
  Process: 20971 ExecStart=/nix/store/63l1lwz19lj4mw03m2ra7m1vnylp8xxl-mariadb-10.3.15/bin/mysqld --defaults-file=/etc/my.cnf --user=mysql --datadir=/var/lib/mysql --basedir=/nix/store/63l1lwz19lj4mw03m2ra7m1vnylp8xxl-mariadb-10.3.15 $_WSREP_NEW_CLUSTER $_WSREP_START_POSITION (code=exited, status=0/SUCCESS)
  Process: 21003 ExecStartPost=/nix/store/gfcwg0a59mz1pmd0ly32ml7ggadaqyqk-unit-script-mysql-post-start (code=exited, status=1/FAILURE)
 Main PID: 20971 (code=exited, status=0/SUCCESS)
   Status: "MariaDB server is down"

Jun 27 12:50:12 hypnos mysqld[20971]: 2019-06-27 12:50:12 0 [Note] /nix/store/63l1lwz19lj4mw03m2ra7m1vnylp8xxl-mariadb-10.3.15/bin/mysqld (initiated by: unknown): Normal shutdown
Jun 27 12:50:12 hypnos mysqld[20971]: 2019-06-27 12:50:12 0 [Note] InnoDB: FTS optimize thread exiting.
Jun 27 12:50:12 hypnos mysqld[20971]: 2019-06-27 12:50:12 0 [Note] InnoDB: Starting shutdown...
Jun 27 12:50:12 hypnos mysqld[20971]: 2019-06-27 12:50:12 0 [Note] InnoDB: Dumping buffer pool(s) to /var/lib/mysql/ib_buffer_pool
Jun 27 12:50:12 hypnos mysqld[20971]: 2019-06-27 12:50:12 0 [Note] InnoDB: Buffer pool(s) dump completed at 190627 12:50:12
Jun 27 12:50:14 hypnos mysqld[20971]: 2019-06-27 12:50:14 0 [Note] InnoDB: Shutdown completed; log sequence number 2217442853; transaction id 6818308
Jun 27 12:50:14 hypnos mysqld[20971]: 2019-06-27 12:50:14 0 [Note] InnoDB: Removed temporary tablespace data file: "ibtmp1"
Jun 27 12:50:14 hypnos mysqld[20971]: 2019-06-27 12:50:14 0 [Note] /nix/store/63l1lwz19lj4mw03m2ra7m1vnylp8xxl-mariadb-10.3.15/bin/mysqld: Shutdown complete
Jun 27 12:50:14 hypnos systemd[1]: mysql.service: Failed with result 'exit-code'.
Jun 27 12:50:14 hypnos systemd[1]: Failed to start MySQL Server.
warning: error(s) occurred while switching to the new configuration

Is there anything missing or something I did wrong? Sorry if it's something trivial.

aanderse · 2019-06-27T10:59:48Z

@pmiddend seems to be a issue with the mysql service potentially unrelated to moodle. Are you running a mysql database on your system? Abby mention in your configuration.nix? Please post output of sudo journalctl -r -u mysql.service.

EDIT: Have you by chance secured your mysql installation? If so this is an unrelated bug in master I have an upcoming PR to fix. More details to come.

aanderse · 2019-07-01T19:03:39Z

@pmiddend the mysql issue has been resolved so if you update your OS to the latest nixpkgs unstable and run again everything should work. I have taken the liberty of adding you as the package maintainer. I hope that is acceptable to you. Please let me know when you get a chance to test.

aanderse · 2019-07-01T19:03:48Z

@GrahamcOfBorg test moodle

pmiddend · 2019-07-02T09:03:40Z

@aanderse Sorry for leaving you hanging like this. I'm a little busy currently. I think I'll have time this week to test.
Also, could you remove me as the maintainer? It's not clear that I'll actually be using moodle in conjunction with NixOS, so maintaining the package doesn't make sense to me.

aanderse · 2019-07-03T11:13:40Z

@pmiddend My apologies for adding you as the maintainer. A bit presumptuous of me.
There was another issue in master which was causing breakage on this module that has been fixed. Please update your channel sometime after the next channel advance and then this module should run for you.

pmiddend · 2019-07-08T19:06:57Z

@aanderse Don't worry about the maintainer status. :)
I'm currently sort of stuck with #63829 so I haven't had a chance to fully test this.

aanderse · 2019-08-27T01:12:33Z

Test takes a while but runs successfully on my machine.

aanderse requested a review from infinisil as a code owner June 21, 2019 21:05

ofborg bot added 6.topic: nixos 8.has: module (update) labels Jun 21, 2019

ofborg bot added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 21, 2019

JohnAZoidberg reviewed Jun 24, 2019

View reviewed changes

aanderse force-pushed the moodle branch from 94647ac to d705fcc Compare June 25, 2019 01:51

aanderse commented Jun 25, 2019

View reviewed changes

nixos/modules/services/web-apps/moodle.nix Show resolved Hide resolved

aanderse force-pushed the moodle branch 2 times, most recently from e0244f7 to 101bb9b Compare June 25, 2019 02:05

JohnAZoidberg reviewed Jun 25, 2019

View reviewed changes

nixos/modules/services/web-apps/moodle.nix Show resolved Hide resolved

aanderse mentioned this pull request Jun 27, 2019

nixos/mysql: run ExecStartPost as root (again) to preserve compatibility with secured installs #63862

Merged

10 tasks

aanderse force-pushed the moodle branch from 101bb9b to cc31756 Compare July 1, 2019 19:01

aanderse force-pushed the moodle branch from cc31756 to b4d73da Compare July 3, 2019 11:11

aanderse force-pushed the moodle branch from b4d73da to 958e9a2 Compare July 11, 2019 13:59

aanderse changed the title ~~moodle: init at 3.7~~ moodle: init at 3.7.1 Jul 11, 2019

aanderse added 2 commits August 25, 2019 08:12

moodle: init at 3.7.1

95b3b63

nixos/moodle: init service

3bd03d2

aanderse force-pushed the moodle branch from 958e9a2 to 3bd03d2 Compare August 25, 2019 12:12

ofborg bot added the 11.by: package-maintainer label Aug 25, 2019

aanderse merged commit 87fdc06 into NixOS:master Aug 27, 2019

aanderse deleted the moodle branch August 27, 2019 01:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

moodle: init at 3.7.1 #63634

moodle: init at 3.7.1 #63634

aanderse commented Jun 21, 2019 •

edited

nixos-discourse commented Jun 21, 2019

aanderse commented Jun 24, 2019

pmiddend commented Jun 27, 2019

aanderse commented Jun 27, 2019 •

edited

aanderse commented Jul 1, 2019

aanderse commented Jul 1, 2019 •

edited

pmiddend commented Jul 2, 2019

aanderse commented Jul 3, 2019 •

edited

pmiddend commented Jul 8, 2019

aanderse commented Aug 27, 2019

moodle: init at 3.7.1 #63634

moodle: init at 3.7.1 #63634

Conversation

aanderse commented Jun 21, 2019 • edited

Motivation for this change

Things not yet done but need to be before merged

Things done

nixos-discourse commented Jun 21, 2019

aanderse commented Jun 24, 2019

pmiddend commented Jun 27, 2019

aanderse commented Jun 27, 2019 • edited

aanderse commented Jul 1, 2019

aanderse commented Jul 1, 2019 • edited

pmiddend commented Jul 2, 2019

aanderse commented Jul 3, 2019 • edited

pmiddend commented Jul 8, 2019

aanderse commented Aug 27, 2019

aanderse commented Jun 21, 2019 •

edited

aanderse commented Jun 27, 2019 •

edited

aanderse commented Jul 1, 2019 •

edited

aanderse commented Jul 3, 2019 •

edited