Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.elpi: 1.2.0 -> 1.4.0 #63727

Closed
wants to merge 1 commit into from
Closed

ocamlPackages.elpi: 1.2.0 -> 1.4.0 #63727

wants to merge 1 commit into from

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 24, 2019

Motivation for this change

Major update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Jun 24, 2019 •
edited

@GrahamcOfBorg build ocamlPackages.elpi

jonringer
jonringer approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why ofBorg failed
$ nix-review pr 63727 passed on NixOS
diff LGTM

[3 built, 14 copied (441.1 MiB), 82.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/63727
1 package were build:
ocamlPackages.elpi

@vbgl
Copy link
Contributor Author

vbgl commented Jun 25, 2019

The bot failed because my first request to it was wrong…

@vbgl vbgl mentioned this pull request Jun 27, 2019
Merged
10 tasks
@vbgl
Copy link
Contributor Author

vbgl commented Jun 27, 2019

Closed by #63811.

@vbgl vbgl closed this Jun 27, 2019
@vbgl vbgl deleted the ocaml-elpi-1.4.0 branch June 27, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @jonringer