Skip to content

Backport "cargo-license: init at 0.2.0" to release-19.03 #63728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2019
Merged

Backport "cargo-license: init at 0.2.0" to release-19.03 #63728

merged 2 commits into from
Jun 26, 2019
+322 −0

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Jun 24, 2019 •
edited
Loading

Motivation for this change

Backport of #63706 to release-19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build cargo-license

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 24, 2019
JohnAZoidberg
JohnAZoidberg reviewed Jun 24, 2019
View reviewed changes
pkgs/tools/package-management/cargo-license/default.nix

cargoSha256 = "0jc84v8fxzzyfkcnfr9vrdblw5vdk54nzpch5lcarzfsarncqxw7";

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage please :)
https://github.com/onur/cargo-license

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will fix.

@basvandijk
cargo-license: init at 0.2.0

Verified

This commit was signed with the committer’s verified signature.
prusnak Pavol Rusnak
GPG key ID: 91F3B339B9A02A3D
Verified
Learn about vigilant mode
4caebbe 
(cherry picked from commit 7720379)
@basvandijk basvandijk force-pushed the cargo-license-0.2.0-release-19.03 branch from 2b3c4c3 to 4caebbe Compare June 25, 2019 13:27
@basvandijk basvandijk self-assigned this Jun 25, 2019
@basvandijk basvandijk added the 2.status: work-in-progress This PR isn't done label Jun 25, 2019
@basvandijk
cargo-license: add meta.homepage
c46acba 
(cherry picked from commit b95c4ce)
@basvandijk basvandijk removed the 2.status: work-in-progress This PR isn't done label Jun 25, 2019
@basvandijk
Copy link
Member Author

@GrahamcOfBorg build cargo-license

@basvandijk basvandijk merged commit 75a88c1 into NixOS:release-19.03 Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg

Assignees

@basvandijk basvandijk

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @JohnAZoidberg