Improve composability of mkShell #63701
Merged
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This improves the composability of
mkShell
in two ways:shellHook
is now also composed. For example running the following expression withnix-shell
:will now result in:
Note that packages in the front of
inputsFrom
have precedence over packages in the back. The outermostmkShell
has precedence over all.mergeInputs
will now result in a more sensible order of$PATH
. For example running following withnix-shell
:results in the following
$PATH
:Previously the order was:
The new order makes more sense because it allows to override
$PATH
in the outermostmkShell
and this order is consistent with theshellHook
precedence.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)