Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 2.3.0 -> 2.3.1 #63644

Merged
merged 1 commit into from Jun 23, 2019
Merged

buildbot: 2.3.0 -> 2.3.1 #63644

merged 1 commit into from Jun 23, 2019

Conversation

lopsided98
Copy link
Contributor

Updates buildbot to the latest version.

I was not able to run the NixOS test on master due to #63627, which broke the test infrastructure, but the test passed on unstable.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98 lopsided98 requested a review from FRidh as a code owner June 22, 2019 03:49
@veprbl
Copy link
Member

veprbl commented Jun 22, 2019

cc maintainers @nand0p @ryansydnor
@GrahamcOfBorg build buildbot buildbot-full buildbot-worker buildbot-ui
Resolves: #63483

@vcunat
Copy link
Member

vcunat commented Jun 22, 2019

The gstreamer problem should be fixed on current master.

@veprbl
Copy link
Member

veprbl commented Jun 22, 2019

@GrahamcOfBorg test buildbot

veprbl
veprbl approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux and x86_64-darwin. NixOS test passes too.

@veprbl veprbl merged commit 203ea0d into NixOS:master Jun 23, 2019
@lopsided98 lopsided98 deleted the buildbot-update branch June 23, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @veprbl @vcunat