Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mosquitto: make the tests run #63716

Merged
merged 1 commit into from Aug 13, 2019
Merged

nixos/mosquitto: make the tests run #63716

merged 1 commit into from Aug 13, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

The test would randomly work/not-work due to races between subscribers and publishers.

We are now using a hardcoded 5 second delay, which is super ugly but at least it works consistently here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gazally
gazally reviewed Aug 8, 2019
View reviewed changes
Copy link
Contributor

@gazally gazally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran this test on my machine and it passes.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/52

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

@GrahamcOfBorg test mosquitto

@peterhoeg peterhoeg merged commit 16bd668 into NixOS:master Aug 13, 2019
@peterhoeg peterhoeg deleted the f/mosquitto branch August 13, 2019 14:45
@peterhoeg peterhoeg restored the f/mosquitto branch August 14, 2019 06:18
@peterhoeg peterhoeg deleted the f/mosquitto branch August 19, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gazally gazally gazally left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @nixos-discourse @mmahut @gazally