Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sccache: init at 0.2.8 #63648

Merged
merged 2 commits into from Jun 23, 2019
Merged

sccache: init at 0.2.8 #63648

merged 2 commits into from Jun 23, 2019

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

This is the beginning of a new compiler cache support for NixOS, starting with the bare package. As discussed here: https://discourse.nixos.org/t/use-sccache-for-rust-compilation-cache/3228 . Currently tests are disabled due to mozilla/sccache#460 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) - not applicable.
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" - non depend.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/use-sccache-for-rust-compilation-cache/3228/5

risicle
risicle reviewed Jun 23, 2019
View reviewed changes
pkgs/development/tools/misc/sccache/default.nix Outdated
];
buildInputs = [
openssl
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build on darwin (tested macos 10.13) this needs ++ stdenv.lib.optional stdenv.isDarwin darwin.apple_sdk.frameworks.Security added to buildInputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing this! I'm adding this after the closing ]. Please let me know if that's not what you meant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@Mic92
Copy link
Member

Mic92 commented Jun 23, 2019

@GrahamcOfBorg build sccache

@Mic92 Mic92 merged commit 024db43 into NixOS:master Jun 23, 2019
@doronbehar doronbehar deleted the package-sccache branch August 22, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @nixos-discourse @Mic92 @risicle