Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unp fixes #63649

Merged
merged 2 commits into from Jun 24, 2019
Merged

Unp fixes #63649

merged 2 commits into from Jun 24, 2019

Conversation

Profpatsch
Copy link
Member

Motivation for this change

unrar was in the default build, making unp unfree. Also fixes the manpage (see commits)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @timor
@GrahamcOfBorg build unp

@Profpatsch
unp: improve file copying & fix manpage
59368e1
@Profpatsch
unp: remove unfree unrar from the default backend list
6fd7090 
`unrar` is unfree, meaning `unp` cannot be built by default if `unrar`
is in its dependencies.

A simple

  env NIXPKGS_ALLOW_UNFREE=1 nix-shell -p unrar

will make `unp` work with .rar files.
@timor
Copy link
Member

timor commented Jun 24, 2019 •
edited

Would it make sense to add the extra archivers as an option like nixpkgs.config.unp.extraBackends?

@timor
Copy link
Member

timor commented Jun 24, 2019

I tested this via nix-review pr --checkout commit 63649, and was able to run unp -U on some random tar.gz archive successfully.

@Profpatsch
Copy link
Member Author

Would it make sense to add the extra archivers as an option like nixpkgs.config.unp.extraBackends?

idk, I don’t use nixpkgs.config because it breaks hermeticity.

@Profpatsch Profpatsch merged commit 7251830 into NixOS:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Profpatsch @timor