Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jazzy: 0.9.6 -> 0.10.0 #63678

Merged
merged 1 commit into from Jul 14, 2019
Merged

jazzy: 0.9.6 -> 0.10.0 #63678

merged 1 commit into from Jul 14, 2019

Conversation

lilyball
Copy link
Member

Also define passthru.updateScript.

Motivation for this change

https://github.com/realm/jazzy/releases/tag/v0.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Jun 23, 2019

Builds for me, macos 10.13

@lilyball
Copy link
Member Author

lilyball commented Jul 3, 2019

Updated the gems again since cocoapods 1.7.3 is out now.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/21

@lilyball
jazzy: 0.9.6 -> 0.10.0
3712d36 
Also define passthru.updateScript.
@lilyball
Copy link
Member Author

lilyball commented Jul 9, 2019

Updated again, this time for cocoapods 1.7.4.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/26

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build jazzy

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 14, 2019 •
edited

Sorry it took so long for someone to review this, the issue was probably the small amount of macos nixpkgs reviewers.

IIRC @marsam uses macos so you should be able to ping them for review on future PRs.

@worldofpeace worldofpeace merged commit 0be5740 into NixOS:master Jul 14, 2019
@lilyball lilyball deleted the jazzy branch July 15, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilyball @risicle @nixos-discourse @worldofpeace