Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/testing: remove leftover of virtualisation.qemu.program #63696

Merged
merged 1 commit into from Nov 18, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 23, 2019

Motivation for this change

Fix #63299

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ckauhaus
Copy link
Contributor

Tried some tests manually (like installer test) and it looks like this change does not break anything. Please bug me if I was wrong!

@ckauhaus ckauhaus merged commit 99e0372 into NixOS:master Nov 18, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 18, 2019

Thank you!

@rnhmjoj rnhmjoj deleted the qemu-program branch January 8, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning: Option `virtualisation.qemu.program' has no description
2 participants