Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.hidapi: enable on darwin #63695

Merged
merged 1 commit into from
Jun 24, 2019
Merged

pythonPackages.hidapi: enable on darwin #63695

merged 1 commit into from
Jun 24, 2019
+6 −3

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jun 23, 2019

Motivation for this change

Package is cross-platform, and only uses libusb on linux and bsd.

Is the with too messy?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@arcnmx arcnmx requested a review from FRidh as a code owner June 23, 2019 17:17
@FRidh
Copy link
Member

FRidh commented Jun 23, 2019

There is no reason for using it, so yes.

@arcnmx arcnmx force-pushed the python-hidapi-darwin branch from 1e11cdf to 32477b2 Compare June 23, 2019 20:31
@arcnmx
Copy link
Member Author

arcnmx commented Jun 23, 2019

There is no reason for using it, so yes.

Assuming this was in response to with, so changed.
(is there ever actually a "reason" to use it though, beyond conventions or personal taste thresholds of line length and brevity?)

@arcnmx
Copy link
Member Author

arcnmx commented Jun 23, 2019 •
edited
Loading

Hm, causing linux rebuilds presumably because of the propagatedBuildInputs list getting reordered. Does it make sense to shuffle that around to save some rebuilds?

{
  propagatedBuildInputs =
    stdenv.lib.optionals stdenv.isLinux [ libusb1 udev ] ++
    stdenv.lib.optionals stdenv.isDarwin [ darwin.IOKit darwin.apple_sdk.frameworks.CoreFoundation ] ++
    [ cython ];
}

EDIT: applied, also is ++ etc the preferred style or?

@arcnmx
pythonPackages.hidapi: enable on darwin

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jonringer Jonathan Ringer
GPG key ID: 5C841D3CFDFEC4E0
Expired
Verified
Learn about vigilant mode
2933681
@arcnmx arcnmx force-pushed the python-hidapi-darwin branch from 32477b2 to 2933681 Compare June 23, 2019 21:55
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 11-100 labels Jun 23, 2019
@matthewbauer matthewbauer merged commit b24d5e4 into NixOS:master Jun 24, 2019
@arcnmx arcnmx deleted the python-hidapi-darwin branch June 24, 2019 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arcnmx @FRidh @matthewbauer