Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lazygit: 0.7.2 -> 0.8 #63694

Merged
merged 1 commit into from Jun 24, 2019
Merged

lazygit: 0.7.2 -> 0.8 #63694

merged 1 commit into from Jun 24, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto
teto approved these changes Jun 24, 2019
View reviewed changes
pkgs/development/tools/lazygit/default.nix
license = licenses.mit;
maintainers = with stdenv.lib.maintainers; [ fpletz ];
platforms = stdenv.lib.platforms.unix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the removal ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to also work on windows, since is has releases for it; and buildGoPackage defaults this to plataform.all

@marsam marsam merged commit bdc4d57 into NixOS:master Jun 24, 2019
@marsam marsam deleted the update-lazygit branch June 24, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @teto