Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddy: disable telemetry #63697

Merged
merged 1 commit into from Oct 28, 2019
Merged

caddy: disable telemetry #63697

merged 1 commit into from Oct 28, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member

What's the reason for disabling telemetry?

@gloaming
Copy link
Contributor

@kalbasit Do we not disable telemetry as a matter of policy? It's disabled in firefox, and searching the repo I see that it's disabled in Powershell and TimescaleDB also.

Mic92
Mic92 reviewed Jun 24, 2019
View reviewed changes
pkgs/servers/caddy/default.nix Outdated

preBuild = ''
substituteInPlace caddy/caddymain/run.go \
--replace "var EnableTelemetry = true" "var EnableTelemetry = false"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a patch instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also nitpick: var EnableTelemetry = false is the same as var EnableTelemetry bool.

@Mic92
Copy link
Member

Mic92 commented Jun 24, 2019

Making a software not transmitting information to third-party services by default is a good practice, we follow in NixOS.

@fpletz
Copy link
Member

fpletz commented Oct 26, 2019

The recommended way by upstream to disable telemetry is to create an new main module: https://github.com/caddyserver/caddy#build. Since we also need this to package caddy modules in the future, I've rewritten this PR to overwrite the default main module with a custom one to disable the telemetry. Also rebased onto the current master.

You can check if telemetry is disabled by checking if caddy -disabled-metrics foo is failing with an error.

@marsam @fpletz
caddy: disable telemetry
b53710e 
Co-authored-by: Franz Pletz <fpletz@fnordicwalking.de>
@marsam
Copy link
Contributor Author

marsam commented Oct 28, 2019

@fpletz it works! thanks a lot for updating it

@fpletz fpletz merged commit ad6f400 into NixOS:master Oct 28, 2019
@marsam marsam deleted the caddy-disable-telemetry branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@fpletz fpletz Awaiting requested review from fpletz

@rushmorem rushmorem Awaiting requested review from rushmorem

@kalbasit kalbasit Awaiting requested review from kalbasit

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @kalbasit @gloaming @Mic92 @fpletz