new: python-modules/tinytag at 1.2.2 #63661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Jun 22, 2019
JohnAZoidberg
requested changes
Jun 22, 2019
There was a problem hiding this comment.
I'd apply these changes.
- With python packages you can take the python dependencies as arguments and you don't need
with python3Packages; [ ...] - The tests are included in the GitHub sources
with ...;is not the best because it's unclear where attributes come from. That's why I try to reduce it's scope in meta
Some tests are still failing. If you've got time, you can figure out why. If not, just disable them again.
--- i/pkgs/development/python-modules/tinytag/default.nix
+++ w/pkgs/development/python-modules/tinytag/default.nix
@@ -1,25 +1,32 @@
-{ stdenv, fetchPypi, substituteAll, python3Packages }:
-
-python3Packages.buildPythonPackage rec {
- version = "1.2.2";
+{ buildPythonPackage, lib, fetchFromGitHub, twine, pytest, pytestcov, coveralls, flake8, isPy3k }:
+buildPythonPackage rec {
pname = "tinytag";
+ version = "1.2.2";
- src = fetchPypi {
- inherit pname version;
- sha256 = "sha256:0r2pazrqq9lxy3an7vvafc6whglnawx2mi8x75gnrr56a02xpr8h";
+ src = fetchFromGitHub {
+ owner = "devsnd";
+ repo = pname;
+ rev = version;
+ sha256 = "1728m4dsnzkw3f5xphjkc7vmlnc2lf4px9a69jixsi924bljmw1s";
};
- propagatedBuildInputs = with python3Packages; [
+ propagatedBuildInputs = [
twine
];
- # No tests
- doCheck = false;
+ checkInputs = [
+ pytest pytestcov coveralls flake8
+ ];
+
+ doCheck = !isPy3k;
+ postCheck = ''
+ python runtests.py
+ '';
- meta = with stdenv.lib; {
- description = "Read music meta data and length of MP3, OGG, OPUS, MP4, M4A, FLAC, WMA and Wave files with python 2 or 3";
+ meta = {
+ description = "Read music meta data and length of MP3, OGG, OPUS, MP4, M4A, FLAC, WMA and Wave files";
homepage = "https://github.com/devsnd/tinytag";
- license = licenses.mit;
- maintainers = [ maintainers.deepfire ];
+ license = lib.licenses.mit;
+ maintainers = with lib.maintainers; [ deepfire ];
};
}
FRidh
requested changes
Jun 23, 2019
| @@ -0,0 +1,25 @@ | |||
| { stdenv, fetchPypi, substituteAll, python3Packages }: | |||
There was a problem hiding this comment.
explicit arguments instead of python3Packages
|
Thank you for your contributions.
|
stale
bot
added
the
2.status: stale
|
no movement in almost a year, going to close. @deepfire feel free to re-open this if you want the package included in nixpkgs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds a python tagging library.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)