jumpapp: init at 1.0 #57893
Merged
jumpapp: init at 1.0 #57893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/packaging-shell-scripts/2447/3 |
danbst
reviewed
Mar 19, 2019
pkgs/tools/X11/jumpapp/default.nix
Outdated
| makeFlags = [ "PREFIX=$(out)" ]; | ||
| buildInputs = [ perl pandoc ]; | ||
| postFixup = let | ||
| runtimePath = lib.makeSearchPath "bin" [ xdotool wmctrl xprop nettools perl ]; |
There was a problem hiding this comment.
what about this approach?
nativeBuildInputs = [ pandoc perl ];
buildInputs = [ xdotool wmctrl xprop nettools ];
postFixup = let
runtimePath = lib.makeBinPath buildInputs;
in ...
This way script will be launchable from nix-shell, for, e.g., script development purposes.
There was a problem hiding this comment.
Neat, didn't realize that nativeBuildInputs can be used in this way. perl is both run-time and build-time dependency, so I've added it to both lists
danbst
reviewed
Mar 19, 2019
pkgs/tools/X11/jumpapp/default.nix
Outdated
| homepage = https://github.com/mkropat/jumpapp; | ||
| description = "A run-or-raise application switcher for any X11 desktop"; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
would you kind sir add yourself as a maintainer, please?
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packaging a useful utility for window management on X11: https://github.com/mkropat/jumpapp
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)