Comparing changes
Open a pull request
base repository: NixOS/nixpkgs-channels
base: 0f3146eda73d
head repository: NixOS/nixpkgs-channels
compare: e4c9a026c199
- 17 commits
- 13 files changed
- 13 contributors
Commits on Mar 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a8307b9 - Browse repository at this point
Copy the full SHA a8307b9View commit details
Commits on Mar 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 11cdd00 - Browse repository at this point
Copy the full SHA 11cdd00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9af5a9a - Browse repository at this point
Copy the full SHA 9af5a9aView commit details -
qemu: Apply interim fix for overlayfs + O_NOATIME
Our VM tests and everything related to our virtualisation infrastructure is currently broken if used with kernel 4.19 or later. The reason for this is that since 4.19, overlayfs uses the O_NOATIME flag when opening files in lowerdir and this doesn't play nice with the way we pass the Nix store to our QEMU guests. On a NixOS system, paths in the Nix store are typically owned by root but the QEMU process is usually run by an ordinary user. Using O_NOATIME on a file where you're not the owner (or superuser) will return with EPERM (Operation not permitted). This is exactly what happens in our VM tests, because we're using overlayfs in the guests to allow writes to the store. Another implication of this is that the default kernel version for NixOS 19.03 has been reverted to Linux 4.14. Work on getting this upstream is still ongoing and the patch I posted previously was incomplete, needs rework and also some more review from upstream maintainers - in summary: This will take a while. So instead of rushing in a kernel patch to nixpkgs, which will affect all users of overlayfs, not just NixOS VM tests, I opted to patch QEMU for now to ignore the O_NOATIME flag in 9p. I think this is also the least impacting change, because even if you care about whether access times are written or not, you get the same behaviour as with Linux 4.19 in conjunction with QEMU. Signed-off-by: aszlig <aszlig@nix.build> Fixes: NixOS/nixpkgs#54509
Configuration menu - View commit details
-
Copy full SHA for 4c1ddb3 - Browse repository at this point
Copy the full SHA 4c1ddb3View commit details -
This reverts commit 048c36c. With the patch applied for fixing the overlayfs bug in QEMU, there really shouldn't stand anything in our way to use 4.19 as the default kernel. Signed-off-by: aszlig <aszlig@nix.build>
Configuration menu - View commit details
-
Copy full SHA for 9a395a4 - Browse repository at this point
Copy the full SHA 9a395a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c330e1 - Browse repository at this point
Copy the full SHA 2c330e1View commit details -
Merge pull request #57776 from lilyball/ffsend
ffsend: init at 0.2.36
Configuration menu - View commit details
-
Copy full SHA for 92a950c - Browse repository at this point
Copy the full SHA 92a950cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1019016 - Browse repository at this point
Copy the full SHA 1019016View commit details -
Configuration menu - View commit details
-
Copy full SHA for f56d507 - Browse repository at this point
Copy the full SHA f56d507View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef00612 - Browse repository at this point
Copy the full SHA ef00612View commit details -
Merge pull request #57880 from basvandijk/megacli-8.07.14
megacli: 8.07.07 -> 8.07.14
Configuration menu - View commit details
-
Copy full SHA for 0b2ae58 - Browse repository at this point
Copy the full SHA 0b2ae58View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7147c8 - Browse repository at this point
Copy the full SHA a7147c8View commit details -
Merge pull request #55856 from jsamsa/xhyve-update
update xhyve to tip of master
Configuration menu - View commit details
-
Copy full SHA for 8fce8a9 - Browse repository at this point
Copy the full SHA 8fce8a9View commit details -
Merge overlayfs fix, LTS kernel bump and test
In Linux 4.19 there has been a major rework of the overlayfs implementation and it now opens files in lowerdir with O_NOATIME, which in turn caused issues in our VM tests because the process owner of QEMU doesn't match the file owner of the lowerdir. The crux here is that 9p propagates the O_NOATIME flag to the host and the guest kernel has no way of verifying whether that flag will lead to any problems beforehand. There is ongoing work to possibly fix this in the kernel, but it will take a while until there is a working patch and consensus. So in order to bring our default kernel back to 4.19 and of course make it possible to run newer kernels in VM tests, I'm merging a small QEMU patch as an interim solution, which we can drop once we have a working fix in the next round of stable kernels. Now we already had Linux 4.19 set as the default kernel, but that was subsequently reverted in 048c36c because the patch we have used was the revert of the commit I bisected a while ago. This patch broke overlayfs in other ways, so I'm also merging in a VM test by @bachp, which only tests whether overlayfs is working, just to be on the safe side that something like this won't happen in the future. Even though this change could be considered a moderate mass-rebuild at least for GNU/Linux, I'm merging this to master, mainly to give us some time to get it into the current 19.03 release branch (and subsequent testing window) once we got no new breaking builds from Hydra. Cc: @samueldr, @lheckemann Fixes: NixOS/nixpkgs#54509 Fixes: NixOS/nixpkgs#48828 Merges: NixOS/nixpkgs#57641 Merges: NixOS/nixpkgs#54508
Configuration menu - View commit details
-
Copy full SHA for 12efcc2 - Browse repository at this point
Copy the full SHA 12efcc2View commit details
Commits on Mar 19, 2019
-
lastwatch: Remove no longer maintained package
I no longer use nor do I maintain this package upstream and with the current version of pylast moving to Python 3, this package is hereby obsolete as I'm not willing to port this to Python 3. Signed-off-by: aszlig <aszlig@nix.build>
Configuration menu - View commit details
-
Copy full SHA for 7c3311d - Browse repository at this point
Copy the full SHA 7c3311dView commit details -
Merge pull request #57048 from 0x4A6F/master-tayga
tayga: init at 0.9.2
Configuration menu - View commit details
-
Copy full SHA for 631ec69 - Browse repository at this point
Copy the full SHA 631ec69View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4c9a02 - Browse repository at this point
Copy the full SHA e4c9a02View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0f3146eda73d...e4c9a026c199