Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resilio-sync: 2.6.2 -> 2.6.3 #57728

Merged
merged 1 commit into from Apr 14, 2019
Merged

resilio-sync: 2.6.2 -> 2.6.3 #57728

merged 1 commit into from Apr 14, 2019

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Mar 15, 2019

Motivation for this change

https://help.resilio.com/hc/en-us/articles/206216855-Sync-2-x-change-log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yesbox yesbox changed the title resilio-sync: 2.6.3 -> 2.6.4 resilio-sync: 2.6.2 -> 2.6.3 Mar 15, 2019
@yesbox
Copy link
Contributor Author

yesbox commented Mar 16, 2019

@lheckemann Could you please backport this to 19.03? This patch "Fixed moving files to Archive and replacing them with 0 bytes files" which sounds important enough.

@yesbox
Copy link
Contributor Author

yesbox commented Mar 23, 2019

Ping maintainers @domenkozar @thoughtpolice @cwoac.

@c0bw3b c0bw3b mentioned this pull request Apr 9, 2019
Merged
@aanderse
Copy link
Member

@yesbox This seems like a pretty straight forward version bump. I double checked your hashes and they are fine. I ran the program with --help flags just to be sure nothing odd.

I also support the idea of a backport because the changelog is minimal, but impacting as far as the zero byte issue is concerned.

LGTM 👍

@aanderse aanderse merged commit 94a8ca2 into NixOS:master Apr 14, 2019
@lheckemann
Copy link
Member

Cherry-picked to 19.03: 88498c0

@yesbox yesbox deleted the resilio_2.6.3 branch September 15, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yesbox @aanderse @lheckemann @infinisil @GrahamcOfBorg