Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: fix Intel C++ Compiler linking issues. #7383

Merged
merged 1 commit into from Mar 18, 2019

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 17, 2019

GetAircraftFlightLevel<Aircraft> is only used in static functions inside aircraft_cmd.cpp. With GCC, Clang and MSVC this is not an issue, but on ICC fails linking, because it doesn't find this version of this template. Possibly these two pieces of information are linked.
Explicit defining the function fixes the issue.

GetAircraftFlightLevel<Aircraft> is only used in static functions
inside aircraft_cmd.cpp. With GCC, Clang and MSVC this is not an
issue, but on ICC fails linking, because it doesn't find this
version of this template. Possibly these two pieces of information
are linked.
Explicit defining the function fixes the issue.
@TrueBrain TrueBrain merged commit fe13fad into OpenTTD:master Mar 18, 2019
@TrueBrain TrueBrain deleted the fix_icc branch March 18, 2019 19:57
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Mar 23, 2019
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants