compcert: fix source hash #57848
compcert: fix source hash #57848
Conversation
GrahamcOfBorg
added
11.by: package-maintainer
| @@ -16,15 +16,14 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| src = fetchurl { | |||
| url = "http://compcert.inria.fr/release/${name}.tgz"; | |||
There was a problem hiding this comment.
This should be more stable https://github.com/AbsInt/CompCert
Hopefully the archives don't defer too much.
There was a problem hiding this comment.
I believe that both sources are tightly coupled. How could one be more stable than the other?
There was a problem hiding this comment.
@worldofpeace is saying that by using the Git repository tags to fetch rather than the inria.fr server, there will probably be no force pushes to master which would retroactively invalidate hashes. Which I'd agree with, and probably would make it more stable in the future if this repeatedly happens -- but in this case we don't even know what changed, unfortunately (there are no commits to CompCert since the 3.5 tag was posted, which is odd...)
|
@xavierleroy any idea why the hashes changes? |
|
Yes, I forgot to update a file, so I re-did the release. The bad release was out for less than 24 hours and hadn't been announced, so I took the liberty of fixing it rather than do another release. I didn't know you packagers worked so fast :-) Release tarballs can be downloaded from caml.inria.fr or from github.com, but I would use github.com as more reliable overall. Finally, there was no commit to master since 3.5 release, indeed. Nothing to worry about, just some work that is going on on branches and that will be merged soon. Hope this answers all your questions. |
|
Thanks for the explanation. I’ve thus updated the package to fetch the sources from the github tag. |
|
@GrahamcOfBorg build compcert |
Motivation for this change
Current package is broken (the contents of the source tarball have been updated).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)