Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pysideTools: fix compilation #57850

Closed

Conversation

FlorianFranzen
Copy link
Contributor

Motivation for this change

"Backport" of #57108 in scope of #56826.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

@GrahamcOfBorg build pythonPackages.pysideTools

@worldofpeace
Copy link
Contributor

In the case of ZHF it's most likely that a committer will backport your pr for you (though they really should make use of ofborg).

Additionally it needs to backported in this manner https://nixos.org/nixpkgs/manual/#submitting-changes-stable-release-branches

Don't fret though, I'll merge and backport #57108 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants