Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: init at 0.2.36 #57776

Merged
merged 1 commit into from Mar 18, 2019
Merged

ffsend: init at 0.2.36 #57776

merged 1 commit into from Mar 18, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

Adds https://gitlab.com/timvisee/ffsend.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Docker nixos/nix image)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've declared Linux support but it's not very well-tested. I've built it in Docker and made sure the resulting binary works, but I haven't tested everything. As you can see from a comment I left in the file, clipboard support is enabled but won't actually work on Linux unless xclip is in the PATH. In theory we could patch the source to run xclip from the Nix store but I didn't want to be responsible for maintaining such a patch when I don't use Linux.

I'm also not sure if there's any need to add cacert, since we're using openssl. It seems to work without that, but I'm not sure where it gets certs from.

@ryantm
Copy link
Member

ryantm commented Mar 17, 2019

@GrahamcOfBorg build ffsend

thanks; please consider adding yourself to the GrahamcOfBorg known users so your PRs can be built automatically.

@lilyball
Copy link
Member Author

failed to fetch https://github.com/rust-lang/crates.io-index
Caused by:
[16/-1] unexpected return value from ssl handshake -9808

Is this an indication that with sandbox on Darwin we need cacert too?

@lilyball
Copy link
Member Author

It occurs to me the dependency on openssl is unrelated to the build failure, because it's failing when trying to start the build, not failing because ffsend uses openssl.

@lilyball lilyball changed the title ffsend: init at 0.2.34 ffsend: init at 0.2.36 Mar 18, 2019
@lilyball
Copy link
Member Author

Ok I checked another Rust package (cargo-tree) and it has the exact same error with ofBorg's Darwin build as this one (https://github.com/NixOS/nixpkgs/runs/77715402). I guess that's just a problem in general with the sandboxed darwin builds of Rust packages.

@lilyball
Copy link
Member Author

I filed NixOS/ofborg#332 about this issue with Rust packages in general.

@ryantm
Copy link
Member

ryantm commented Mar 18, 2019

@GrahamcOfBorg build ffsend

@lilyball, if you've tested building on Darwin, I think it's fine for us to merge and see how it goes. Maybe Hydra won't have the same issue?

@timvisee
Copy link

It seems cargo fails to update it's package index due to a failing SSL handshake. Could this be because of missing/outdated SSL certificates or an incorrect host configuration?

See this log: https://logs.nix.ci/?attempt_id=765d3576-eb30-4c9d-8c7a-ca36aa030751&key=nixos%2Fnixpkgs.57776

@lilyball
Copy link
Member Author

I just realized cargo-tree didn't have a prebuilt Darwin binary when I installed it the other day. I bet this is why.

@timvisee My current assumption is the sandboxed Darwin builder is preventing access to the /etc/ssl/ certs. It's also possible that /etc/ssl/ has obsolete certs in it, given that the OpenSSL that Apple ships is horribly obsolete, but I don't know how to test.

@7c6f434c 7c6f434c merged commit 92a950c into NixOS:master Mar 18, 2019
@lilyball lilyball deleted the ffsend branch March 18, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lilyball @ryantm @timvisee @7c6f434c @GrahamcOfBorg