Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jcal: init at 0.4.1 #57760

Merged
merged 2 commits into from Mar 16, 2019
Merged

jcal: init at 0.4.1 #57760

merged 2 commits into from Mar 16, 2019

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Mar 16, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb
srhb requested changes Mar 16, 2019
View reviewed changes
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/jcal/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

Thank you for contributing to nixpkgs! I've left some comments, I hope they all make sense, otherwise please holler :)

@LinArcX
Copy link
Contributor Author

LinArcX commented Mar 16, 2019

@srhb Should i create new pull request and fix those changes?
Sorry, it's my first pr and i don't know about it's process.

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

@LinArcX Please feel free to ask all the questions you need to get a feel for the process, it's totally fine and we're happy to help!

You should amend this PR by (force-)pushing changes to your branch. This PR will update automatically then, and we keep all the comments and discussion in the same place. :)

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

@GrahamcOfBorg build jcal

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

Yay! Thanks for contributing!

@srhb srhb merged commit 44b5166 into NixOS:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LinArcX @srhb @GrahamcOfBorg @Janik-Haag