Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocat: Fix on macOS #57895

Merged
merged 1 commit into from Mar 27, 2019
Merged

websocat: Fix on macOS #57895

merged 1 commit into from Mar 27, 2019

Conversation

Kaali
Copy link

@Kaali Kaali commented Mar 19, 2019

Motivation for this change

websocat did not compile on macOS because of a missing framework.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 19, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 19, 2019

@GrahamcOfBorg build websocat

thoughtpolice
thoughtpolice requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures from ofborg look legitimate -- notably, we'll have to skip the tests on macOS it seems like due to EPERM errors...

@Kaali
Copy link
Author

Kaali commented Mar 19, 2019

Where do I see ofborg logs?

@stephengroat
Copy link
Contributor

@Kaali https://logs.nix.ci/?attempt_id=d483d8c3-ee8e-4809-9df1-340d9389bd8c&key=nixos%2Fnixpkgs.57895

@Kaali
Copy link
Author

Kaali commented Mar 23, 2019

Test failures from ofborg look legitimate -- notably, we'll have to skip the tests on macOS it seems like due to EPERM errors...

Does ofborg do something other than run nix-build -A websocat? As that worked for me on this commit.

@Kaali Kaali changed the title Fix websocat on macOS websocat: Fix on macOS Mar 27, 2019
@Kaali
Copy link
Author

Kaali commented Mar 27, 2019

Rebased on top of master and changed the title so ofborg evaluates it automatically.

@Kaali
Copy link
Author

Kaali commented Mar 27, 2019

All tests seem to be passing now.

@thoughtpolice thoughtpolice merged commit d984875 into NixOS:master Mar 27, 2019
@thoughtpolice
Copy link
Member

Thanks! Sorry this took a bit of time to get in.

@Kaali
Copy link
Author

Kaali commented Mar 27, 2019

No problem. Thanks

@Kaali Kaali deleted the websocat-macos branch March 27, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kaali @Mic92 @stephengroat @thoughtpolice @GrahamcOfBorg