Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus-table: revert 1.9.21 -> 1.9.20 #57732

Closed
wants to merge 2 commits into from

Conversation

laMudri
Copy link
Contributor

@laMudri laMudri commented Mar 15, 2019

Motivation for this change

Reverts the two commits of #53080, because of issue #56621.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

xeji
xeji previously requested changes Mar 16, 2019
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these 13 commits look like they don't belong here.

@laMudri
Copy link
Contributor Author

laMudri commented Apr 7, 2019

I've now cleaned this up and tested again.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 15, 2019

I would prefer a proper fix with wrapGAppsHook.

@laMudri
Copy link
Contributor Author

laMudri commented Aug 20, 2019

Better solution at #61978.

@laMudri laMudri closed this Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants