Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yojson: 1.6.0 -> 1.7.0 #57726

Closed
wants to merge 1 commit into from
Closed

yojson: 1.6.0 -> 1.7.0 #57726

wants to merge 1 commit into from

Conversation

aij
Copy link
Contributor

@aij aij commented Mar 15, 2019

Motivation for this change

Upgrade to be able to fix deprecation warnings introduced in 1.6.0. See ocaml-community/yojson#79

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

@GrahamcOfBorg build ocamlPackages.yojson

@xeji
Copy link
Contributor

xeji commented Mar 15, 2019

this was already updated in fdb95b4
closing.

@xeji xeji closed this Mar 15, 2019
@aij
Copy link
Contributor Author

aij commented Mar 16, 2019

Oops, sorry about that.

@aij aij deleted the yojson branch March 16, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aij @xeji @GrahamcOfBorg