Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pyalgotrade: fix build #57724

Merged
merged 2 commits into from Mar 19, 2019
Merged

python.pkgs.pyalgotrade: fix build #57724

merged 2 commits into from Mar 19, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 15, 2019 •
edited

Motivation for this change

Doing a PR because I get transient download errors locally.
EDIT: Seems they are also experienced by ofborg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @offlinehacker

@dotlambda dotlambda added 2.status: work-in-progress 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 15, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner March 15, 2019 21:20
@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.pyalgotrade python3.pkgs.pyalgotrade

@dotlambda
Copy link
Member Author

@FRidh Do you have an idea where the download error could be coming from?

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python2.pkgs.pyalgotrade python3.pkgs.pyalgotrade

@dotlambda dotlambda merged commit 3172140 into NixOS:master Mar 19, 2019
@dotlambda dotlambda deleted the pyalgotrade-fix branch March 21, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @GrahamcOfBorg