Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 0.7.1 -> 0.7.2 #57725

Merged
merged 1 commit into from Mar 15, 2019
Merged

broot: 0.7.1 -> 0.7.2 #57725

merged 1 commit into from Mar 15, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Mar 15, 2019

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

xeji
xeji approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

darwin error looks unrelated to this PR, I've seen that error several times with other packages

@xeji xeji merged commit a2a6a21 into NixOS:master Mar 15, 2019
@dywedir dywedir deleted the broot branch March 15, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @xeji @GrahamcOfBorg