Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python.section.md #57883

Closed
wants to merge 2 commits into from
Closed

Update python.section.md #57883

wants to merge 2 commits into from

Conversation

biggs
Copy link
Contributor

@biggs biggs commented Mar 19, 2019 •
edited

Motivation for this change

Bug in the number of braces fixed and syntax cleared up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@biggs
Update python.section.md
f309000 
Bug in the number of braces fixed and syntax cleared up.
@biggs biggs requested a review from FRidh as a code owner March 19, 2019 00:02
@worldofpeace
Copy link
Contributor

I noticed that other examples take this pattern that you noted is incorrect.

Would you mind fixing them also? Just changing the one would make it inconsistent.

@biggs
Copy link
Contributor Author

biggs commented Mar 19, 2019

Sure thing, I'll go ahead and make the changes when I have a moment

@biggs
Copy link
Contributor Author

biggs commented Mar 22, 2019

Had a look and didn't see any other examples that needed to be changed. They were intendend as non-standalone sections of a larger statement.

@worldofpeace
Copy link
Contributor

Merged in 1e86c0a.

Thanks for the fix @biggs ❇️

@worldofpeace
Copy link
Contributor

backported in 149e1d3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@biggs @worldofpeace @FRidh @GrahamcOfBorg @Janik-Haag