Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: fix darwin sandboxed build #57839

Closed
wants to merge 1 commit into from
Closed

go: fix darwin sandboxed build #57839

wants to merge 1 commit into from

Conversation

kalbasit
Copy link
Member

Motivation for this change

Extracting 09e36a7c247490f1f11f29c2bf80fce3cb11336d from #57711.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 18, 2019
@LnL7 @kalbasit
go: fix darwin sandboxed build
dd92948 
(cherry picked from commit 09e36a7c247490f1f11f29c2bf80fce3cb11336d)
@kalbasit kalbasit force-pushed the nixpkgs_fix-go-tests-on-darwin branch from f853a2c to dd92948 Compare March 18, 2019 02:14
@kalbasit
Copy link
Member Author

Never mind. I'm going to close this since it'll rebuild all the Go packages anyway.

@kalbasit kalbasit closed this Mar 18, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-go-tests-on-darwin branch March 18, 2019 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kalbasit @GrahamcOfBorg @LnL7