lab: generate and install zsh completion #57842
Conversation
|
Oh! Ha, well this is because I forgot to upstream porting `lab` over to
the new `buildGoModule` goodness.
Which apparently has different behavior re:outputs?
Doesn't matter here, but that's why $out worked for me :3.
Will address in a few.
…On Sun, 17 Mar 2019 21:22:52 -0700, worldofpeace ***@***.***> wrote:
worldofpeace commented on this pull request.
> @@ -17,6 +17,12 @@ buildGoPackage rec {
goDeps = ./deps.nix;
+ postInstall = ''
+ mkdir -p $out/share/zsh/site-functions
+ LAB_CORE_HOST=a LAB_CORE_USER=b LAB_CORE_TOKEN=c \
+ $out/bin/lab completion zsh > $out/share/zsh/site-functions/_lab
```suggestion
$bin/bin/lab completion zsh > $bin/share/zsh/site-functions/_lab
```
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#57842 (review) part: text/html
|
Hmm, I wasn't aware of @kalbasit Any reason why the outputs for |
It seems it's more that Anyway, merging this as it should be ready now! |
|
Just kidding, hashes are wrong? They might depend on something I have changed, will check sorry. |
dtzWill
force-pushed
the
feature/lab/zsh-completion
branch
from
b13cc17
to
c03e493
Compare
|
Weird they're still wrong. 😕 |
The initial version of buildGoModule had both the $bin and the $out outputs. However, @Mic92 pointed out that all of the buildGoPackage derivations had a useful output ($bin) and a rather empty and useless output $out and he was unable to consolidate both due to all packages (and possibly outside nixpkgs) usage of buildGoPackage. Since buildGoModule was a new infrastructure, we wanted to consolidate the outputs.
https://kalbas.it/2019/03/17/announcing-the-new-golang-infrastructure-buildgomodule/ :) |
Right, all outputs should provide some sort of use. Think you made the correct decision there.
Nice writeup 👍 Thank you for your contributions to the Golang infrastructure. |
| goDeps = ./deps.nix; | ||
| subPackages = [ "." ]; | ||
|
|
||
| modSha256 = "0bw47dd1b46ywsian2b957a4ipm77ncidipzri9ra39paqlv7abb"; |
There was a problem hiding this comment.
| modSha256 = "0bw47dd1b46ywsian2b957a4ipm77ncidipzri9ra39paqlv7abb"; | |
| modSha256 = "1g72fnkibmdd9i20wgp5fjf556xp2xwan06dmn3f5rkmnicy3ccl"; |
as reported by ofborg.
Env variables are set to dummy values so `lab` doesn't get stuck trying to helpfully interact with user for initial configuration.
dtzWill
force-pushed
the
feature/lab/zsh-completion
branch
from
c03e493
to
68ded8b
Compare
Motivation for this change
zsh completion! :)
Env variables are set to dummy values
so
labdoesn't get stuck trying to helpfullyinteract with user for initial configuration.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)