colord: 1.4.2 -> 1.4.4 #57840
Merged
colord: 1.4.2 -> 1.4.4 #57840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
commented
Mar 18, 2019
| "-Denable-docs=false" | ||
| "-Dinstalled_tests=true" | ||
| "-Dlibcolordcompat=true" | ||
| "-Dsane=true" |
There was a problem hiding this comment.
Can't remember if there were problems with sane here.
jtojnar
reviewed
Mar 18, 2019
| ]; | ||
|
|
||
| nativeBuildInputs = [ meson pkgconfig vala_0_40 ninja gettext libxml2 gobject-introspection makeWrapper ]; | ||
| nativeBuildInputs = [ | ||
| docbook_xsl |
There was a problem hiding this comment.
Hmm, I should have probably ported the api docs to Docbook 5 too.
|
The installed test for NixOS should be easy to do: #34987 The separate user sounds good but I agree that it is out of scope of this PR. |
worldofpeace
force-pushed
the
colord/bump
branch
from
9b2a926
to
d31a23d
Compare
|
Had to add a patch for the tests. I've ran them, think it was a success. |
* multiple outputs * enable all docs * installed tests https://github.com/hughsie/colord/blob/1.4.3/NEWS https://github.com/hughsie/colord/blob/1.4.4/NEWS
worldofpeace
force-pushed
the
colord/bump
branch
from
d31a23d
to
5e7623a
Compare
|
Just saw this pr #56504 |
jtojnar
approved these changes
Mar 18, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes
News Items
https://github.com/hughsie/colord/blob/1.4.3/NEWS
https://github.com/hughsie/colord/blob/1.4.4/NEWS
Possible improvements
colorduser for the daemon instead of running as rootThis would probably be a good follow up.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)