Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby_{5,6}_x: update, security fixes #57762

Merged
merged 3 commits into from Mar 17, 2019
Merged

ruby_{5,6}_x: update, security fixes #57762

merged 3 commits into from Mar 17, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 16, 2019

Motivation for this change

https://www.ruby-lang.org/en/news/2019/03/13/ruby-2-5-4-released/
https://www.ruby-lang.org/en/news/2019/03/15/ruby-2-5-5-released/
https://www.ruby-lang.org/en/news/2019/03/13/ruby-2-6-2-released/

backport please

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa markuskowa merged commit 342773c into NixOS:master Mar 17, 2019
@alyssais
Copy link
Member

alyssais commented Mar 17, 2019 via email

@alyssais
Copy link
Member

alyssais commented Mar 17, 2019 via email

@markuskowa
Copy link
Member

Yes, that is weird. I definitely did not merge that PR.

@alyssais
Copy link
Member

alyssais commented Mar 17, 2019 via email

@marsam marsam deleted the update-ruby branch March 17, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marsam @alyssais @markuskowa @GrahamcOfBorg