Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc{822,863}Binary: fix to work w/musl again, __strdup -> strdup #57784

Merged
merged 2 commits into from Mar 18, 2019
Merged

ghc{822,863}Binary: fix to work w/musl again, __strdup -> strdup #57784

merged 2 commits into from Mar 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 17, 2019

Motivation for this change

Fixes #57238.

Should be backported to any release branch impacted by the issue.
Which I think is just 19.03 :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mostly was trying to fix the binary bootstrap build,
have not thoroughly tested the resulting compilers
(particularly the many versions built from these)
are all functioning reasonably...

I think if this at least fixes pkgsMusl.ghc it's a win :).

@roberth
Copy link
Member

roberth commented Mar 17, 2019

Does not impact non-musl 👍

Non-blocking question: this seems to be the host runtime system, which will be linked into stage1. Can't stage1 use glibc and emit a musl stage2?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 18, 2019

Non-blocking question: this seems to be the host runtime system, which will be linked into stage1. Can't stage1 use glibc and emit a musl stage2?

I don't know enough about ghc's compilation infrastructure to say, but that seems reasonable.
Since most of what we use this for is to build the other compilers, is that different than handling across stages?

@roberth
Copy link
Member

roberth commented Mar 18, 2019

I really can't judge how easy or hard it is either.

@dtzWill dtzWill merged commit 3ff71fc into NixOS:master Mar 18, 2019
@dtzWill dtzWill deleted the fix/ghc-musl-strdup branch March 18, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth roberth approved these changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can no longer build GHC with Musl
3 participants
@dtzWill @roberth @GrahamcOfBorg