Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepass-keepassotpkeyprov: init at 2.6 #57786

Merged
merged 2 commits into from Nov 3, 2019
Merged

keepass-keepassotpkeyprov: init at 2.6 #57786

merged 2 commits into from Nov 3, 2019

Conversation

Enteee
Copy link
Contributor

@Enteee Enteee commented Mar 17, 2019 •
edited

Motivation for this change

From the Keepass plugin doc:

OtpKeyProv is a key provider based on one-time passwords. After protecting your database using this plugin, you need to generate and enter one-time passwords in order to open your database.

All generator tokens that follow the OATH HOTP standard (RFC 4226) are supported.

Template for this change was #23893

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/31

c0bw3b
c0bw3b reviewed Nov 2, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a little comment.
@Enteee could you also do your addition to maintainers list in a separate commit maintainers: add Enteee please ?

Then I'll see this finally gets merged. :)

pkgs/applications/misc/keepass-plugins/keepassotpkeyprov/default.nix Outdated Show resolved Hide resolved
@c0bw3b c0bw3b self-assigned this Nov 2, 2019
@c0bw3b c0bw3b merged commit 36c6d76 into NixOS:master Nov 3, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2019

Here we go! 🚀
Thanks @Enteee for your patience & availability to see this through.

@Enteee
Copy link
Contributor Author

Enteee commented Nov 3, 2019

Thank you @JohnAZoidberg , @c0bw3b for reviewing & merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees

@c0bw3b c0bw3b

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Enteee @nixos-discourse @c0bw3b @JohnAZoidberg @GrahamcOfBorg @Janik-Haag