Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minicom: wrap required binaries #57845

Merged
merged 1 commit into from Apr 3, 2019
Merged

minicom: wrap required binaries #57845

merged 1 commit into from Apr 3, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Wrap a few needed binaries

Cc: @Enzime @tomfitzhenry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 19, 2019

Where does the 2.7.90 version come from?

@peterhoeg
Copy link
Member Author

Note to self - make better notes so I can answer questions like these when I finally get around to opening a PR for a change made 6 months earlier.....

I don't remember why - and as there seems to be no security fixes in master, I have amended this PR to only shift the upstream, wrap the required binaries and pick the commit from the release branch.

@peterhoeg peterhoeg changed the title minicom: 2.7.1 -> 2.7.90 minicom: wrap required binaries Mar 19, 2019
@peterhoeg peterhoeg merged commit a4ec5e4 into NixOS:master Apr 3, 2019
@peterhoeg peterhoeg deleted the u/minicom branch April 3, 2019 14:44
@peterhoeg peterhoeg restored the u/minicom branch April 4, 2019 03:01
@peterhoeg peterhoeg deleted the u/minicom branch April 7, 2019 13:18
@peterhoeg peterhoeg restored the u/minicom branch April 8, 2019 03:34
@peterhoeg peterhoeg deleted the u/minicom branch April 8, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @ryantm @GrahamcOfBorg