[Gecko Bug 1021926] mozlog: move the capture io class from web-platform/tests to mozlog (bug 1021926) #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Mar 16, 2019
|
@jgraham what's the plan on landing this? wait till the next mozlog release? |
|
It looks like the issue is that the capture.py created in mozlog is not recognised as a valid import. Could this be because the current mozlog requirement for WPT needs updating? I'm still new to the way WPT relates to Mozilla Central, so correct me if I'm wrong! @jgraham have I missed anything? Thanks! |
|
@nikk15 if you want to bump the version number in |
Seems still be running with mozlog 4.0, despite #16994 landing? |
…bug 1021926) The ability to capture the parent process' stdio is suggested to be a useful feature to move from web-platform/tests into mozlog. To do so, I have created a new capture.py file within mozlog/mozlog. This includes the CaptureIO class and its dependencies, including the LoggingWrapper and LogThread classes. These have been removed from their original location, to avoid duplication, and the files depending on them updated accordingly. It would be useful to add unittests testing the CaptureIO enter and exit methods, and the original_stdio, logging_queue and logging_thread properties. I have begun such a file with test_capture.py in mozlog/tests. This is a work in progress, however I may need some guidance, please, in regards to creating appropriate mock data to assert. Differential Revision: https://phabricator.services.mozilla.com/D22166 gecko-commit: f6705b8320496d0e67213299773e0c429f2b63ef gecko-integration-branch: central gecko-reviewers: jgraham
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to capture the parent process' stdio is suggested to be a useful feature
to move from web-platform/tests into mozlog. To do so, I have created a new capture.py
file within mozlog/mozlog. This includes the CaptureIO class and its dependencies,
including the LoggingWrapper and LogThread classes. These have been removed from their
original location, to avoid duplication, and the files depending on them updated
accordingly.
It would be useful to add unittests testing the CaptureIO enter and exit methods, and
the original_stdio, logging_queue and logging_thread properties. I have begun such a
file with test_capture.py in mozlog/tests. This is a work in progress, however I may
need some guidance, please, in regards to creating appropriate mock data to assert.
Differential Revision: https://phabricator.services.mozilla.com/D22166
gecko-commit: f6705b8320496d0e67213299773e0c429f2b63ef
gecko-integration-branch: central
gecko-reviewers: jgraham