Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg_4: build with videotoolbox on darwin #57743

Merged
merged 1 commit into from Apr 11, 2019
Merged

ffmpeg_4: build with videotoolbox on darwin #57743

merged 1 commit into from Apr 11, 2019

Conversation

ryan4729
Copy link
Contributor

Motivation for this change

Build ffmpeg_4 with Apple's VideoToolbox video acceleration framework. The motivation for this change was to be able to use hardware accelerated playback on the mpv video player on macOS. After this change, you can see that mpv <video_file> --msg-level=all=v --hwdec=videotoolbox provides hardware accelerated playback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

veprbl
veprbl approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and got CPU load reduced by a factor of 3 or more. Definitely useful!

@veprbl veprbl merged commit 49c646c into NixOS:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryan4729 @veprbl @GrahamcOfBorg