Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csvkit: move out of pythonPackages #57745

Merged
merged 2 commits into from Mar 18, 2019
Merged

csvkit: move out of pythonPackages #57745

merged 2 commits into from Mar 18, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 16, 2019 •
edited

Motivation for this change

From https://csvkit.readthedocs.io/en/1.0.3/index.html:

csvkit is a suite of command-line tools for [...]

The build was previously broken, which is fixed by updating agate-excel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 16, 2019
@dotlambda dotlambda requested a review from vrthra March 16, 2019 09:26
@dotlambda dotlambda requested a review from FRidh as a code owner March 16, 2019 09:26
@dotlambda
Copy link
Member Author

Now that agate-excel has made an official release with the fix I'll merge this within 24 hours if noone objects.

@dotlambda dotlambda merged commit 8ec6905 into NixOS:master Mar 18, 2019
@dotlambda
Copy link
Member Author

backported in b5bf9f3 and 57e067f

@dotlambda dotlambda deleted the csvkit-no-library branch March 21, 2019 09:31
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @samueldr @GrahamcOfBorg