ulauncher: init at 4.4.0.r1 #57859
ulauncher: init at 4.4.0.r1 #57859
Conversation
|
Oops, almost forgot to ping @worldofpeace |
|
Thank you, @jtojnar, for doing a review. I pushed a commit that should resolve almost all of the issues apart from using |
|
They provide an icon at |
|
Thanks for the effort. Fyi, "preferences" section is not working with current state with following message:
|
|
I think someone else should take ove rfrom here. I don't think I have enough experience with Nix to fix that and some of the suggested changes. |
Understandable. I've supplied the requested changes in 067b0e6 and fixed what @seqizz mentioned. |
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
worldofpeace
force-pushed
the
patch-ulauncher
branch
from
067b0e6
to
a9a03c7
Compare
|
Thanks a lot to @aaronjanse and our reviewers. ✨ |
Motivation for this change
Package ulauncher for NixOS (fix #51049).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Side note: I recently renamed my github account from @aaronduino to @aaronjanse.
I thought if I would do so eventually, it would be best to do so before adding my github username to the maintainers list. I updated the relevant gist links in issues I have written and commented on.