Skip to content

ulauncher: init at 4.4.0.r1 #57859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2019
Merged

ulauncher: init at 4.4.0.r1 #57859

merged 1 commit into from
Jun 1, 2019
+136 −0

Conversation

aaronjanse
Copy link
Member

Motivation for this change

Package ulauncher for NixOS (fix #51049).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Side note: I recently renamed my github account from @aaronduino to @aaronjanse.
I thought if I would do so eventually, it would be best to do so before adding my github username to the maintainers list. I updated the relevant gist links in issues I have written and commented on.

Sorry, something went wrong.

@aaronjanse
Copy link
Member Author

Oops, almost forgot to ping @worldofpeace

jtojnar
jtojnar requested changes Mar 18, 2019
View reviewed changes
@aaronjanse
Copy link
Member Author

Thank you, @jtojnar, for doing a review. I pushed a commit that should resolve almost all of the issues apart from using wrapProgram. I replied with a more detail on the relevant review thread.

@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 18, 2019
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 18, 2019
@worldofpeace
Copy link
Contributor

They provide an icon at hicolor so I think we should put hicolor-icon-theme in buildInputs.
Even if we don't need the setup hook, I think it's a good idea for it to be there.

@seqizz seqizz mentioned this pull request May 28, 2019
Open
@seqizz
Copy link
Contributor

seqizz commented May 29, 2019

Thanks for the effort. Fyi, "preferences" section is not working with current state with following message:

Error opening file /nix/store/sz54qsfrhl83zj86nf3zkbbg4akh4w5y-ulauncher-4.3.2.r8/share/ulauncher/preferences/dist/index.html: No such file or directory

@aaronjanse
Copy link
Member Author

I think someone else should take ove rfrom here. I don't think I have enough experience with Nix to fix that and some of the suggested changes.

@worldofpeace worldofpeace mentioned this pull request Jun 1, 2019
Open
@worldofpeace
Copy link
Contributor

I think someone else should take ove rfrom here. I don't think I have enough experience with Nix to fix that and some of the suggested changes.

Understandable. I've supplied the requested changes in 067b0e6 and fixed what @seqizz mentioned.
(#57859 (comment))

@aaronjanse @worldofpeace
ulauncher: init at 4.4.0.r1

Verified

This commit was signed with the committer’s verified signature.
tadeokondrak Tadeo Kondrak
GPG key ID: D41E092CA43F1D8B
Verified
Learn about vigilant mode
a9a03c7 
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@worldofpeace worldofpeace changed the title ulauncher: init at 4.3.2.r8 ulauncher: init at 4.4.0.r1 Jun 1, 2019
@worldofpeace worldofpeace merged commit d1259d0 into NixOS:master Jun 1, 2019
@worldofpeace
Copy link
Contributor

Thanks a lot to @aaronjanse and our reviewers. ✨

@ofborg ofborg bot requested a review from worldofpeace June 1, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Ulauncher
5 participants
@aaronjanse @worldofpeace @seqizz @jtojnar @GrahamcOfBorg