Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discussion] systems: add armv7 target #57823

Closed
wants to merge 1 commit into from
Closed

[discussion] systems: add armv7 target #57823

wants to merge 1 commit into from

Conversation

illegalprime
Copy link
Member

Motivation for this change

recently i've been working on #56540 , to try to cross compile into armv7l (beaglebone), but rust doesn't explicitly support armv7l, it supports armv7. So a few things can be done:

  1. Add an armv7 target.
  2. Map { family = "arm"; version = "7"; } architectures to armv7 within buildRustCrate and the rust compiler.
  3. something else?

what do you think is best?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

armv7 and armv7l should be the same architecture.

@illegalprime
Copy link
Member Author

so maybe it's reasonable to do no. 2? or both no. 1 and no. 2?

@matthewbauer
Copy link
Member

I think 2. makes sense for now.

@illegalprime
Copy link
Member Author

OK I'll add the functionality to Rust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illegalprime @matthewbauer @GrahamcOfBorg