Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

highlight: use $CXX instead of c++ to build #57821

Merged
merged 1 commit into from Mar 18, 2019
Merged

highlight: use $CXX instead of c++ to build #57821

merged 1 commit into from Mar 18, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

set $CXX and $AR so cross compilation works

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

@GrahamcOfBorg build highlight

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

@illegalprime could you ask for ofborg access? NixOS/ofborg#331

@illegalprime
Copy link
Member Author

@Mic92 thanks, will do!

@Mic92 Mic92 merged commit d9fc44e into NixOS:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illegalprime @Mic92 @GrahamcOfBorg